Skip to content

http2: keep reading during small client writes#63009

Open
mcollina wants to merge 1 commit intonodejs:mainfrom
mcollina:http2-perf
Open

http2: keep reading during small client writes#63009
mcollina wants to merge 1 commit intonodejs:mainfrom
mcollina:http2-perf

Conversation

@mcollina
Copy link
Copy Markdown
Member

Fixes: #54874

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net
  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Apr 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.64%. Comparing base (58a8e1d) to head (4dd0542).
⚠️ Report is 147 commits behind head on main.

Files with missing lines Patch % Lines
src/node_http2.cc 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63009      +/-   ##
==========================================
- Coverage   89.69%   89.64%   -0.05%     
==========================================
  Files         706      708       +2     
  Lines      218222   220331    +2109     
  Branches    41768    42262     +494     
==========================================
+ Hits       195731   197520    +1789     
- Misses      14411    14657     +246     
- Partials     8080     8154      +74     
Files with missing lines Coverage Δ
src/node_http2.h 91.61% <ø> (ø)
src/node_http2.cc 82.12% <90.00%> (+0.02%) ⬆️

... and 88 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTTP2 download of parallel requests is slower than HTTP1.1

2 participants